Add issue-id template variable, support multiple replacements (not just the first occurrence)#29
Open
okdas wants to merge 2 commits intodessant:mainfrom
Open
Add issue-id template variable, support multiple replacements (not just the first occurrence)#29okdas wants to merge 2 commits intodessant:mainfrom
issue-id template variable, support multiple replacements (not just the first occurrence)#29okdas wants to merge 2 commits intodessant:mainfrom
Conversation
Author
|
Tested here: okdas/test-actions#1 (comment) @dessant Please let me know if there's anything else needs to be done to get this in. Thanks! |
5 tasks
|
@dessant Bump |
Author
|
I've discovered this only replaces the first mention of |
Author
|
Modified the replace() calls to use global regular expressions (/g flag) instead of string literals. This ensures all instances of {issue-author} and {issue-id} are replaced, not just the first occurrence. Here's an example of working global replace: pokt-network/poktroll#702 (comment) @dessant can we get this in please? |
6 tasks
okdas
changed the title
issue-id template variableissue-id template variable, support multiple replacements (not just the first occurrence)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to programmatically generate some URLs to point to the different development dashboards (we provision new environment for each PR).
issue-idvariable would become handy. Will test this change in the near future.